Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: system diagnostic monitor #4722

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Aug 23, 2023

Description

The diagnostic monitor extends the diagnostic and outputs the top-level operation status of Autoware for MRM. See #3829 (comment) for details.

Related links

tier4/tier4_autoware_msgs#96
#3829 (comment)

Tests performed

  1. Launch planning simulation
  2. Launch diagnostics nodes
    • ros2 launch system_diagnostic_monitor system_diagnostic_monitor.launch.xml
  3. Launch diagnostics monitor and check all status are OK
    • ros2 run rqt_runtime_monitor rqt_runtime_monitor --ros-args -r diagnostics:=diagnostics_array

Notes for reviewers

This PR depends on tier4/tier4_autoware_msgs#96.

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi self-assigned this Aug 23, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Aug 23, 2023
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi changed the title Feat/system diagnostic graph feat: system diagnostic monitor Aug 23, 2023
@isamu-takagi isamu-takagi marked this pull request as ready for review August 23, 2023 08:34
Copy link
Contributor

@asana17 asana17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your outstanding contribution!

system/system_diagnostic_graph/example/publisher.py Outdated Show resolved Hide resolved
@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 417 lines in your changes are missing coverage. Please review.

Comparison is base (a25cbe0) 15.92% compared to head (123428c) 15.86%.
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4722      +/-   ##
==========================================
- Coverage   15.92%   15.86%   -0.07%     
==========================================
  Files        1580     1592      +12     
  Lines      109009   109426     +417     
  Branches    33616    33616              
==========================================
  Hits        17361    17361              
- Misses      73034    73451     +417     
  Partials    18614    18614              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.92% <ø> (ø) Carriedforward from a25cbe0

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
system/system_diagnostic_graph/src/core/expr.hpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/update.hpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/config.hpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/node.hpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/debug.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/main.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/tool.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/node.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/graph.cpp 0.00% <0.00%> (ø)
system/system_diagnostic_graph/src/core/update.cpp 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 443386d into autowarefoundation:main Sep 26, 2023
45 of 49 checks passed
@isamu-takagi isamu-takagi deleted the feat/system-diagnostic-graph branch September 26, 2023 04:08
isamu-takagi added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants