Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detection_by_tracker): add debug and modify existence_probability #475

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Mar 3, 2022

Related Issue(required)

Description(required)

  • Added visualization of detection by tracker
  • existence probability was fixed at 0.1. In this PR, it is changed to 2d IoU.

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yukkysaito yukkysaito changed the base branch from tier4/proposal to main March 3, 2022 09:55
@yukkysaito yukkysaito closed this Mar 3, 2022
@yukkysaito yukkysaito deleted the feature/add_debug_in_detection_by_tracking branch March 3, 2022 09:57
@yukkysaito yukkysaito restored the feature/add_debug_in_detection_by_tracking branch March 3, 2022 09:57
@yukkysaito yukkysaito reopened this Mar 3, 2022
Signed-off-by: Yukihiro Saito <[email protected]>
@yukkysaito yukkysaito force-pushed the feature/add_debug_in_detection_by_tracking branch from 93022de to ab3bddd Compare March 3, 2022 11:40
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #475 (1ef27ed) into main (14afa55) will decrease coverage by 10.97%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #475       +/-   ##
==========================================
- Coverage   10.97%   0.00%   -10.98%     
==========================================
  Files         704       4      -700     
  Lines       49562     326    -49236     
  Branches     6647       0     -6647     
==========================================
- Hits         5440       0     -5440     
+ Misses      39760     326    -39434     
+ Partials     4362       0     -4362     
Impacted Files Coverage Δ
..._tracker/include/detection_by_tracker/debugger.hpp 0.00% <0.00%> (ø)
...detection_by_tracker/detection_by_tracker_core.hpp 0.00% <ø> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <0.00%> (ø)
...onstants_manager/src/vehicle_constants_manager.cpp
...ion/include/shape_estimation/filter/bus_filter.hpp
...er/scene_module/scene_module_bt_node_interface.hpp
common/osqp_interface/src/csc_matrix_conv.cpp
...er/src/voxel_grid_based_euclidean_cluster_node.cpp
...nclude/system_error_monitor/diagnostics_filter.hpp
...idar_apollo_instance_segmentation/disjoint_set.hpp
... and 694 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14afa55...1ef27ed. Read the comment docs.

@yukkysaito yukkysaito changed the title Feature/add debug in detection by tracking feat(detection_by_tracker) : Feature/add debug in detection by tracking Mar 3, 2022
@yukkysaito yukkysaito changed the title feat(detection_by_tracker) : Feature/add debug in detection by tracking feat(detection_by_tracker) : add debug and modify existence_probability Mar 3, 2022
@yukkysaito yukkysaito changed the title feat(detection_by_tracker) : add debug and modify existence_probability feat(detection_by_tracker): add debug and modify existence_probability Mar 3, 2022
Signed-off-by: Yukihiro Saito <[email protected]>
@yukkysaito yukkysaito marked this pull request as ready for review March 4, 2022 06:06
@yukkysaito
Copy link
Contributor Author

I confirmed to work in my pc

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito merged commit 84d3790 into autowarefoundation:main Mar 10, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#475)

* add debugger

Signed-off-by: Yukihiro Saito <[email protected]>

* change iou

Signed-off-by: Yukihiro Saito <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#475)

* add debugger

Signed-off-by: Yukihiro Saito <[email protected]>

* change iou

Signed-off-by: Yukihiro Saito <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#475)

* add debugger

Signed-off-by: Yukihiro Saito <[email protected]>

* change iou

Signed-off-by: Yukihiro Saito <[email protected]>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Kenji Miyake <[email protected]>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants