Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_extension,map_loader): add guard_rail wall fence as lanelet tag #478

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Mar 4, 2022

Related Issue(required)

#258

Description(required)

add guard_rail fence wall as partition lanelet and visualize it in Rviz

this PR add

  • lanelet2 tag of guard rail fence wall to recognize sidewalk geometry.
    this PR wont consider
  • 3D geometry or color of guard_rails fence wall in lanelet2_map.osm, because there are plenty of color variation and geometry.

Review Procedure(required)

  1. download lanelet map from fms as prd_jt -> kashiwanoha_dev
    https://tools.tier4.jp/vector_map_builder_ll2/

  2. launch psim and see map tag is correctly visualized in Rviz
    image

Related PR(optional)

for testing taikitanaka3#5

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3 taikitanaka3 changed the title feat(lanelet2_extension,map_loader) add guard rails wall fence as lanelet tag feat(lanelet2_extension,map_loader): add guard rails wall fence as lanelet tag Mar 4, 2022
@taikitanaka3 taikitanaka3 changed the title feat(lanelet2_extension,map_loader): add guard rails wall fence as lanelet tag feat(lanelet2_extension,map_loader): add guard_rail wall fence as lanelet tag Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #478 (8118ad7) into main (14afa55) will decrease coverage by 8.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #478      +/-   ##
=========================================
- Coverage   10.97%   2.77%   -8.21%     
=========================================
  Files         704     198     -506     
  Lines       49562   17225   -32337     
  Branches     6647    1599    -5048     
=========================================
- Hits         5440     478    -4962     
+ Misses      39760   16347   -23413     
+ Partials     4362     400    -3962     
Impacted Files Coverage Δ
map/lanelet2_extension/lib/query.cpp 9.76% <0.00%> (-0.21%) ⬇️
...et2_map_loader/lanelet2_map_visualization_node.cpp 0.00% <0.00%> (ø)
...re_utils/test/src/geometry/test_pose_deviation.cpp
...ocity_converter/src/vehicle_velocity_converter.cpp
...ption_rviz_plugin/src/tools/delete_all_objects.cpp
...ulator/vehicle_model/sim_model_ideal_steer_vel.cpp
...map_calibrator/accel_brake_map_calibrator_node.hpp
...ject_tracker/data_association/data_association.hpp
..._smoother/analytical_jerk_constrained_smoother.cpp
...ommon/osqp_interface/test/test_csc_matrix_conv.cpp
... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14afa55...8118ad7. Read the comment docs.

@tkimura4 tkimura4 removed their request for review March 4, 2022 04:49
@taikitanaka3 taikitanaka3 merged commit d638b95 into autowarefoundation:main Mar 5, 2022
taikitanaka3 referenced this pull request in tier4/autoware.universe Mar 16, 2022
…elet tag (#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 9, 2022
…elet tag (#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
@taikitanaka3 taikitanaka3 deleted the 258-feat-add-guard_rails-wall-fence-as-lanelet-tag branch April 13, 2022 09:54
taikitanaka3 referenced this pull request in tier4/autoware.universe Apr 14, 2022
…elet tag (#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
…elet tag (autowarefoundation#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…elet tag (tier4#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…elet tag (tier4#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…elet tag (tier4#478)

* feat(lanelet2_extension): add guard_rails fence wall as lanelet tag

Signed-off-by: tanaka3 <[email protected]>

* feat(map_loader): add visualization for partion lanelet

Signed-off-by: tanaka3 <[email protected]>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: h-ohta <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request May 17, 2023
…k/pr3654

fix(behavior_velocity_planner): fixed virtual wall marker id duplication  (autowarefoundation#3654)
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants