Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(walkway): fix module launch condition #4823

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 30, 2023

Description

🤖 Generated by Copilot at 0dc1f94

Refactor and simplify the walkway manager module in manager.cpp. Use a local argument for regulatory elements instead of a class member.


Fix module launch condition so that it can activate walkway module in the map which has both regulatory element crosswalk and non regulatory element walkway.

map: X2 Dev/Shiojiri_100laps_Dev/20230828_修正完了_14

image

simplescreenrecorder-2023-08-31_08.22.57.mp4

Tests performed

Effects on system behavior

Make it possible to use walkway module in specific map.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 30, 2023
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f04a37) 15.12% compared to head (516a4e8) 15.13%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4823   +/-   ##
=======================================
  Coverage   15.12%   15.13%           
=======================================
  Files        1573     1573           
  Lines      108302   108281   -21     
  Branches    33269    33251   -18     
=======================================
- Hits        16386    16384    -2     
+ Misses      74067    74050   -17     
+ Partials    17849    17847    -2     
Flag Coverage Δ *Carryforward flag
differential 24.03% <0.00%> (?)
total 15.13% <ø> (+<0.01%) ⬆️ Carriedforward from 5f04a37

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../ar_tag_based_localizer/src/tag_tf_caster_core.cpp 0.00% <ø> (ø)
...let2_map_preprocessor/src/fix_lane_change_tags.cpp 0.00% <ø> (ø)
...raffic_light_arbiter/src/traffic_light_arbiter.cpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 9.09% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <ø> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.38% <ø> (-0.13%) ⬇️
.../utils/goal_planner/default_fixed_goal_planner.cpp 0.00% <ø> (ø)
...g/behavior_velocity_walkway_module/src/manager.cpp 24.32% <0.00%> (+1.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Aug 30, 2023
@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Aug 30, 2023

NOTE: 796d9b2 is a temporary commit in order to pass build.

@github-actions github-actions bot removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Aug 31, 2023
@satoshi-ota
Copy link
Contributor Author

NOTE: 796d9b2 is a temporary commit in order to pass build.

REMOVED.

@zhiwango
Copy link

image
@satoshi-ota
ローカルPCで該当のPRを入れた後に、PSIMで動作確認はできました。
修正ありがとうございます。

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 enabled auto-merge (squash) August 31, 2023 02:21
@tkimura4 tkimura4 merged commit 1b1ac5c into autowarefoundation:main Aug 31, 2023
25 of 27 checks passed
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 31, 2023
@satoshi-ota satoshi-ota deleted the fix/walkway-launch-cond branch August 31, 2023 05:26
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants