-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(walkway): fix module launch condition #4823
fix(walkway): fix module launch condition #4823
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4823 +/- ##
=======================================
Coverage 15.12% 15.13%
=======================================
Files 1573 1573
Lines 108302 108281 -21
Branches 33269 33251 -18
=======================================
- Hits 16386 16384 -2
+ Misses 74067 74050 -17
+ Partials 17849 17847 -2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
e507eb9
to
796d9b2
Compare
NOTE: 796d9b2 is a temporary commit in order to pass build. |
Signed-off-by: satoshi-ota <[email protected]>
796d9b2
to
516a4e8
Compare
REMOVED. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Description
🤖 Generated by Copilot at 0dc1f94
Refactor and simplify the walkway manager module in
manager.cpp
. Use a local argument for regulatory elements instead of a class member.Fix module launch condition so that it can activate walkway module in the map which has both regulatory element crosswalk and non regulatory element walkway.
map: X2 Dev/Shiojiri_100laps_Dev/20230828_修正完了_14
simplescreenrecorder-2023-08-31_08.22.57.mp4
Tests performed
Effects on system behavior
Make it possible to use walkway module in specific map.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.