Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behavior_path_planner): fix object_check_min_road_shoulder_width explanation #4834

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Aug 31, 2023

Description

Explanation for object_check_min_road_shoulder_width is missed.
I add it.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 31, 2023
@rej55 rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 31, 2023
@rej55 rej55 enabled auto-merge (squash) August 31, 2023 08:32
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (1b1ac5c) 15.10% compared to head (9b13bfb) 15.10%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4834      +/-   ##
==========================================
- Coverage   15.10%   15.10%   -0.01%     
==========================================
  Files        1573     1573              
  Lines      108318   108324       +6     
  Branches    33250    33253       +3     
==========================================
  Hits        16366    16366              
- Misses      74118    74124       +6     
  Partials    17834    17834              
Flag Coverage Δ *Carryforward flag
differential 13.01% <0.00%> (?)
total 15.10% <ø> (ø) Carriedforward from 1b1ac5c

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 15.55% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.30% <0.00%> (-0.06%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.05% <0.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit 8e6d440 into autowarefoundation:main Aug 31, 2023
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants