Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ar_tag_based_localizer): added small changes #4885

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Sep 5, 2023

Description

Multiple small changes added.

  • Changed Qos for the input image topic from reliable to best_effort.
  • Changed to dynamically scale covariance according to recognition distance.
  • Changed camera_frame_ to be taken from the received image topic instead of keeping it as a member variable
  • Added the sample simulation data from AWSIM.

Tests performed

for deault Autoware (i.e. pose_source:=ndt)

  • logging_simulator (sample rosbag)
  • driving_log_replayer (sample rosbag)
  • AWSIM

for ar_tag_based_localizer (pose_source:=artag)

  • logging_simulator (sample data 1 / Real world data)
  • logging_simulator (sample data 2 / AWSIM)

Evaluation Result

Method Mean Error[m]
Odometry Only 2.766
Odometry + AR-Tag 0.627
Odometry + NDT(Default Autoware) 0.053

Effects on system behavior

If AR tag-based self-location estimation is used, the behavior changes slightly. Otherwise, there is no change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Sep 5, 2023
@SakodaShintaro SakodaShintaro self-assigned this Sep 5, 2023
Signed-off-by: Shintaro SAKODA <[email protected]>
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2023
@SakodaShintaro SakodaShintaro changed the title fix(ar_tag_based_localizer): added small changed fix(ar_tag_based_localizer): added small changes Sep 5, 2023
@SakodaShintaro SakodaShintaro marked this pull request as ready for review September 5, 2023 07:16
@KYabuuchi
Copy link
Contributor

Thank you for creating the PR! I have tried your new rosbag.
The position is corrected each time an AR marker is detected, so I think it is functioning as intended.

artag_with_rosbag_made_by_awsim.mp4

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.72% ⚠️

Comparison is base (a25cbe0) 15.92% compared to head (e044442) 15.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4885      +/-   ##
==========================================
- Coverage   15.92%   15.21%   -0.72%     
==========================================
  Files        1580     1578       -2     
  Lines      109009   108201     -808     
  Branches    33616    33185     -431     
==========================================
- Hits        17359    16461     -898     
- Misses      73035    73853     +818     
+ Partials    18615    17887     -728     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.21% <ø> (-0.71%) ⬇️ Carriedforward from 0d83680

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ased_localizer/src/ar_tag_based_localizer_core.cpp 0.00% <0.00%> (ø)

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro
Copy link
Contributor Author

@KYabuuchi
Thanks for your review!
The upper limit was revised to 13 m. 0d83680
With this change, there is now less lateral shift except for the last tag.

In fact, it would be better if the AR tag placement could be improved to observe within 10 m. In AWSIM, the vehicle is a full-size car, so the AR tag is placed about 12~13 m away from the car.

In the use case assumed by AR tag-based self-localization, such as a small car, it would be possible to place it with such constraints.

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Also, I have confirmed that excessive position correction has been improved due to changes in the detection limit.

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) September 6, 2023 07:19
Copy link
Contributor

@Motsu-san Motsu-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit 5e9f992 into autowarefoundation:main Sep 11, 2023
20 of 24 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/ar_tag_based_localizer_qos branch September 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants