-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ar_tag_based_localizer): added small changes #4885
fix(ar_tag_based_localizer): added small changes #4885
Conversation
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Signed-off-by: Shintaro SAKODA <[email protected]>
Thank you for creating the PR! I have tried your new rosbag. artag_with_rosbag_made_by_awsim.mp4 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
==========================================
- Coverage 15.92% 15.21% -0.72%
==========================================
Files 1580 1578 -2
Lines 109009 108201 -808
Branches 33616 33185 -431
==========================================
- Hits 17359 16461 -898
- Misses 73035 73853 +818
+ Partials 18615 17887 -728
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Shintaro SAKODA <[email protected]>
@KYabuuchi In fact, it would be better if the AR tag placement could be improved to observe within 10 m. In AWSIM, the vehicle is a full-size car, so the AR tag is placed about 12~13 m away from the car. In the use case assumed by AR tag-based self-localization, such as a small car, it would be possible to place it with such constraints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Also, I have confirmed that excessive position correction has been improved due to changes in the detection limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5e9f992
into
autowarefoundation:main
Description
Multiple small changes added.
reliable
tobest_effort
.camera_frame_
to be taken from the received image topic instead of keeping it as a member variableTests performed
for deault Autoware (i.e.
pose_source:=ndt
)for ar_tag_based_localizer (
pose_source:=artag
)Evaluation Result
Effects on system behavior
If AR tag-based self-location estimation is used, the behavior changes slightly. Otherwise, there is no change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.