Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): stuck stop line generation when ego is over fist conflicting area #4903

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 6, 2023

Description

Related links

https://tier4.atlassian.net/browse/RT1-3267
https://tier4.atlassian.net/browse/RT1-3696
https://tier4.atlassian.net/browse/RT1-3618

Tests performed

Psim

evaluator
https://evaluation.tier4.jp/evaluation/reports/42ec3b4b-cad9-5708-8d3d-669c8d5c00a5?project_id=prd_jt

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 6, 2023
@soblin soblin force-pushed the fix/intersection/stuck-vehicle-stop-line-when-approached-detection-area branch 2 times, most recently from 25b333d to cbd68e4 Compare September 11, 2023 14:19
@soblin soblin force-pushed the fix/intersection/stuck-vehicle-stop-line-when-approached-detection-area branch from cbd68e4 to 4dac270 Compare September 12, 2023 00:26
@soblin soblin marked this pull request as ready for review September 12, 2023 07:05
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@soblin soblin enabled auto-merge (squash) September 12, 2023 08:02
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (f08e64d) 15.90% compared to head (4dac270) 15.84%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4903      +/-   ##
==========================================
- Coverage   15.90%   15.84%   -0.07%     
==========================================
  Files        1580     1580              
  Lines      109159   109865     +706     
  Branches    33634    34165     +531     
==========================================
+ Hits        17363    17404      +41     
- Misses      73169    73727     +558     
- Partials    18627    18734     +107     
Flag Coverage Δ *Carryforward flag
differential 6.86% <0.00%> (?)
total 15.92% <ø> (+0.01%) ⬆️ Carriedforward from f08e64d

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit bcf52e0 into autowarefoundation:main Sep 12, 2023
30 of 34 checks passed
@soblin soblin deleted the fix/intersection/stuck-vehicle-stop-line-when-approached-detection-area branch September 12, 2023 09:41
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
soblin added a commit to soblin/autoware.universe that referenced this pull request Sep 26, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants