fix(voxel_grid_downsample_filter): support no intensity case #4922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
fast_voxel_grid_downsample_filter
whenuse_down_sample_filter
is set toTrue
inpointcloud_map_filter.launch.py
.A validity check has been added because the pointcloud intensity field is not present in this scenario.
Related links
faster_voxel_grid_downsample_filter
Tests performed
I have confirmed that rosbag replay simulation works when
use_down_sample_filter
is set toTrue
inpointcloud_map_filter.launch.py
.In addition, I have comfirmed the following between point clouds with the same timestamp before and after this PR:
To reproduce: https://github.com/atsushi421/compare_topic_echo
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.