Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): crop backward path to start from narrow space #4929

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 8, 2023

Description

crop backward path to start from narrow space

before

image

after

image

image

Related links

Tests performed

psim

https://evaluation.tier4.jp/evaluation/reports/c248c06c-6557-5d52-a552-e17ff68e1246?project_id=prd_jt
1650/1650

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 8, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 42.10% and no project coverage change.

Comparison is base (cdc568d) 15.91% compared to head (cb994ae) 15.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4929   +/-   ##
=======================================
  Coverage   15.91%   15.92%           
=======================================
  Files        1580     1580           
  Lines      109068   109084   +16     
  Branches    33634    33644   +10     
=======================================
+ Hits        17363    17373   +10     
+ Misses      73079    73078    -1     
- Partials    18626    18633    +7     
Flag Coverage Δ *Carryforward flag
differential 18.54% <42.10%> (?)
total 15.92% <ø> (+<0.01%) ⬆️ Carriedforward from cdc568d

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...planner/src/utils/start_planner/shift_pull_out.cpp 54.77% <42.10%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 8, 2023

removes points which are out of lanes up to the start pose.

image

image

image

@kosuke55 kosuke55 force-pushed the fix/crop_backward_path branch 3 times, most recently from ed67b4e to 6ec39cb Compare September 11, 2023 05:54
@kosuke55
Copy link
Contributor Author

@kyoichi-sugahara
scenario tests passed! could you please approve this PR?

https://evaluation.tier4.jp/evaluation/reports/c248c06c-6557-5d52-a552-e17ff68e1246?project_id=prd_jt
1650/1650

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit ca3731b into main Sep 12, 2023
24 of 26 checks passed
@kosuke55 kosuke55 deleted the fix/crop_backward_path branch September 12, 2023 02:51
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…towarefoundation#4929)

* fix(start_planner): crop backward path to start from narrow space

Signed-off-by: kosuke55 <[email protected]>

* check out of lanes

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Sep 12, 2023
…towarefoundation#4929)

* fix(start_planner): crop backward path to start from narrow space

Signed-off-by: kosuke55 <[email protected]>

* check out of lanes

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…towarefoundation#4929)

* fix(start_planner): crop backward path to start from narrow space

Signed-off-by: kosuke55 <[email protected]>

* check out of lanes

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…towarefoundation#4929)

* fix(start_planner): crop backward path to start from narrow space

Signed-off-by: kosuke55 <[email protected]>

* check out of lanes

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
…towarefoundation#4929)

* fix(start_planner): crop backward path to start from narrow space

Signed-off-by: kosuke55 <[email protected]>

* check out of lanes

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants