Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix path update #4931

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 8, 2023

Description

The update cycle is observed only at the beginning due to !last_pull_out_start_update_time_ .
fix this issue and use update cycle not only for backward driving

Related links

Tests performed

psim

https://evaluation.tier4.jp/evaluation/reports/57953752-50c7-5dd6-a095-f55eaa7719cd?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 8, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b498c53) 15.93% compared to head (46bf7a8) 15.94%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4931   +/-   ##
=======================================
  Coverage   15.93%   15.94%           
=======================================
  Files        1580     1580           
  Lines      108931   108932    +1     
  Branches    33612    33613    +1     
=======================================
+ Hits        17357    17365    +8     
+ Misses      72958    72951    -7     
  Partials    18616    18616           
Flag Coverage Δ *Carryforward flag
differential 17.64% <100.00%> (?)
total 15.93% <ø> (+<0.01%) ⬆️ Carriedforward from b498c53

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...cene_module/start_planner/start_planner_module.cpp 36.89% <100.00%> (+0.79%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 82006db into main Sep 12, 2023
40 of 41 checks passed
@kosuke55 kosuke55 deleted the fix/start_planner_path_update branch September 12, 2023 02:52
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants