Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove tier4_autoware_utils.hpp/motion_utils.hpp from other planning packages #4940

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 9, 2023

Description

#4821

Tests performed

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 9, 2023
@soblin soblin marked this pull request as ready for review September 9, 2023 16:44
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (38b9e1c) 15.92% compared to head (328d239) 15.92%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4940   +/-   ##
=======================================
  Coverage   15.92%   15.92%           
=======================================
  Files        1580     1580           
  Lines      109006   109006           
  Branches    33612    33612           
=======================================
  Hits        17354    17354           
  Misses      73034    73034           
  Partials    18618    18618           
Flag Coverage Δ *Carryforward flag
differential 22.92% <ø> (?)
total 15.92% <ø> (ø) Carriedforward from 38b9e1c

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 50.00% <ø> (ø)
...rivable_area_expansion/drivable_area_expansion.cpp 36.00% <ø> (ø)
...ng/behavior_path_planner/test/test_turn_signal.cpp 46.66% <ø> (ø)
...behavior_velocity_out_of_lane_module/src/debug.cpp 54.00% <ø> (ø)
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.09% <ø> (ø)
...r/src/freespace_planner/freespace_planner_node.cpp 30.34% <ø> (ø)
...ace_planning_algorithms/src/abstract_algorithm.cpp 80.55% <ø> (ø)
...freespace_planning_algorithms/src/astar_search.cpp 72.90% <ø> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 21.80% <ø> (ø)
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% <ø> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin
Copy link
Contributor Author

soblin commented Sep 11, 2023

@takayuki5168 @maxime-clem Can you approve this PR ?

@soblin soblin merged commit ccdf539 into autowarefoundation:main Sep 12, 2023
31 of 32 checks passed
@soblin soblin deleted the build-fast2/component/planning/miscs/remove-motion_utils_motion_utils_hpp branch September 12, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants