Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception_replayer): initialize class variables to prevent crashes #4944

Conversation

maxime-clem
Copy link
Contributor

Description

Some uninitialized variables in the perception_replayer can cause crashes depending on the topics contained in the bag used.
This PR fixes these crashes.

Tests performed

Rosbag test.

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 11, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a25cbe0) 15.92% compared to head (35f688f) 15.92%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4944   +/-   ##
=======================================
  Coverage   15.92%   15.92%           
=======================================
  Files        1580     1580           
  Lines      109009   109009           
  Branches    33616    33616           
=======================================
  Hits        17361    17361           
  Misses      73034    73034           
  Partials    18614    18614           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.92% <ø> (ø) Carriedforward from a25cbe0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 80b6281 into autowarefoundation:main Sep 11, 2023
33 checks passed
@maxime-clem maxime-clem deleted the fix/perception_replayer-uninitialized branch September 11, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants