Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_rviz_plugin): add package #4945

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 11, 2023

Description

Add tier4_system_rviz_plugin

Currently it supports MRM visualizer.

Among the output of autoware_auto_system_msgs::msg::HazardStatusStamped, it extracts the latent fault and single point fault, and then visualize the underlying diagnostic status summary whose level is ERROR or WARN. Note that it does not show the highest level diagnostics which is defined in system_error_monitor.

image

image

Related links

Tests performed

  • Launch autoware and verified that the RViz launches without any error
  • By enabling the plugin, the summary pops up on RViz.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 11, 2023
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 13, 2023
@kminoda kminoda marked this pull request as ready for review September 13, 2023 01:29
Signed-off-by: kminoda <[email protected]>
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (9402bb5) 15.75% compared to head (aa2ff85) 15.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4945      +/-   ##
==========================================
- Coverage   15.75%   15.72%   -0.03%     
==========================================
  Files        1584     1586       +2     
  Lines      109568   109763     +195     
  Branches    33728    33728              
==========================================
  Hits        17258    17258              
- Misses      73692    73887     +195     
  Partials    18618    18618              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.75% <ø> (ø) Carriedforward from 9402bb5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...tier4_system_rviz_plugin/src/jsk_overlay_utils.cpp 0.00% <0.00%> (ø)
...em_rviz_plugin/src/mrm_summary_overlay_display.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit 4247a70 into autowarefoundation:main Sep 13, 2023
20 of 23 checks passed
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Sep 13, 2023
* feat(tier4_system_rviz_plugin): add package

Signed-off-by: kminoda <[email protected]>

* update maintainer

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* minor update

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* update some arguments

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* fix pre-commit

Signed-off-by: kminoda <[email protected]>

* style(pre-commit): autofix

* update maintainer

Signed-off-by: kminoda <[email protected]>

* fix test

Signed-off-by: kminoda <[email protected]>

---------

Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda referenced this pull request in tier4/autoware.universe Sep 13, 2023
feat(tier4_system_rviz_plugin): add package (autowarefoundation#4945)
@kminoda kminoda deleted the feat/tier4_system_rviz_plugin/add_package branch September 26, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants