Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): update parameter value #4955

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Sep 12, 2023

Description

Update default launcher parameter iou_threshold : 0.35 -> 0.65.
Also, the default values are removed specified in RoIClusterFusion node.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 12, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@ktro2828 ktro2828 enabled auto-merge (squash) September 12, 2023 04:48
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (82006db) 15.80% compared to head (9597347) 15.77%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4955      +/-   ##
==========================================
- Coverage   15.80%   15.77%   -0.04%     
==========================================
  Files        1580     1585       +5     
  Lines      109179   109416     +237     
  Branches    33646    33646              
==========================================
  Hits        17258    17258              
- Misses      73313    73550     +237     
  Partials    18608    18608              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.80% <ø> (+<0.01%) ⬆️ Carriedforward from 82006db

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 15.76% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktro2828 ktro2828 changed the title fix: update parameter value fix(image_projection_based_fusion): update parameter value Sep 12, 2023
@ktro2828 ktro2828 force-pushed the fix/image_projection_based_fusion/update_params branch from f3c3cdd to 9597347 Compare September 12, 2023 05:32
@ktro2828 ktro2828 merged commit 64ed461 into autowarefoundation:main Sep 12, 2023
20 of 22 checks passed
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
@ktro2828 ktro2828 deleted the fix/image_projection_based_fusion/update_params branch April 2, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants