-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(image_projection_based_fusion): update parameter value #4955
fix(image_projection_based_fusion): update parameter value #4955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
==========================================
- Coverage 15.80% 15.77% -0.04%
==========================================
Files 1580 1585 +5
Lines 109179 109416 +237
Branches 33646 33646
==========================================
Hits 17258 17258
- Misses 73313 73550 +237
Partials 18608 18608
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: ktro2828 <[email protected]>
f3c3cdd
to
9597347
Compare
Signed-off-by: ktro2828 <[email protected]>
Description
Update default launcher parameter
iou_threshold : 0.35 -> 0.65
.Also, the default values are removed specified in RoIClusterFusion node.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.