fix(mission_planner/behavior_path_planner): use transient local for modified goal #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified goal Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
isamu-takagi,
mitsudome-r,
TakaHoribe,
takayuki5168,
purewater0901,
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
changed the title
kosuke55
added
the
tag:run-build-and-test-differential
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5012 +/- ##
==========================================
- Coverage 15.74% 15.74% -0.01%
==========================================
Files 1587 1587
Lines 109831 109833 +2
Branches 33719 33720 +1
==========================================
Hits 17292 17292
- Misses 73908 73909 +1
- Partials 18631 18632 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
approved these changes
Sep 19, 2023
TakaHoribe
approved these changes
Sep 19, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…odified goal (autowarefoundation#5012) fix(mission_planner/behavior_path_planner): use trasient local for modified goal Signed-off-by: kosuke55 <[email protected]>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…odified goal (autowarefoundation#5012) fix(mission_planner/behavior_path_planner): use trasient local for modified goal Signed-off-by: kosuke55 <[email protected]>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…odified goal (autowarefoundation#5012) fix(mission_planner/behavior_path_planner): use trasient local for modified goal Signed-off-by: kosuke55 <[email protected]>
4 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 19, 2023
…odified goal (autowarefoundation#5012) (#852) fix(mission_planner/behavior_path_planner): use trasient local for modified goal Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use trasient local for modified goal for pub/sub because mission planner sometimes does not receive it.
modified goal may be published in 10hz at most, so we need to see if this setting is appropriate.
Related links
https://tier4.atlassian.net/browse/RT1-3626
Tests performed
psim
2023/09/17 https://evaluation.tier4.jp/evaluation/reports/f969ecb1-628a-590a-a41a-258300212e8f/?project_id=prd_jt
1668/1668
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.