Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): added logging initial pose #5045

Conversation

SakodaShintaro
Copy link
Contributor

Description

Added code to log input and output Pose of initial position estimation in align_using_monte_carlo.

Tests performed

It was confirmed that it can be successfully executed against sample rosbag.

Effects on system behavior

Each time an initial position estimation is performed using NDT, the following three lines of log are output.

Each value is (x, y, z, qx, qy, qz, qw, roll, pitch, yaw(deg), cov(0,0), cov(1,1), ... cov(5, 5)).

1695192506.8527462 [ndt_scan_matcher-31] [INFO 1695192506.851505952] [localization.pose_estimator.ndt_scan_matcher]: align_using_monte_carlo_input,89570.098658,42300.198565,-3.188279,0.000363,-0.007508,0.018195,0.999806,0.025985,-0.860952,2.084941,1.000000,1.000000,0.010000,0.010000,0.010000,10.000000
...
1695192509.4600489 [ndt_scan_matcher-31] [INFO 1695192509.439114040] [localization.pose_estimator.ndt_scan_matcher]: align_using_monte_carlo_output,89571.156250,42301.187500,-3.157603,-0.008684,-0.001767,0.287582,0.957715,-1.011302,0.092282,33.427036,0.000000,0.000000,0.000000,0.000000,0.000000,0.000000
1695192509.4605412 [ndt_scan_matcher-31] [INFO 1695192509.439304247] [localization.pose_estimator.ndt_scan_matcher]: best_score,5.89776

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <[email protected]>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 20, 2023
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@SakodaShintaro SakodaShintaro changed the title feat(ndt_scan_matcher) : added logging initial pose feat(ndt_scan_matcher): added logging initial pose Sep 20, 2023
@SakodaShintaro SakodaShintaro enabled auto-merge (squash) September 20, 2023 07:06
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (909f12f) 15.71% compared to head (9b8936d) 15.71%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5045      +/-   ##
==========================================
- Coverage   15.71%   15.71%   -0.01%     
==========================================
  Files        1579     1579              
  Lines      109342   109346       +4     
  Branches    34106    34103       -3     
==========================================
  Hits        17188    17188              
- Misses      73239    73243       +4     
  Partials    18915    18915              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.72% <ø> (+<0.01%) ⬆️ Carriedforward from 909f12f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
...calizer/include/ekf_localizer/hyper_parameters.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)
...can_matcher/include/ndt_scan_matcher/util_func.hpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
localization/ndt_scan_matcher/src/util_func.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 7.81% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 12.77% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR. It's cool 👍
2023-09-20_16-12

@SakodaShintaro SakodaShintaro merged commit c7525bb into autowarefoundation:main Sep 20, 2023
22 of 24 checks passed
@SakodaShintaro SakodaShintaro deleted the feat/add_logging_initial_pose branch September 20, 2023 07:13
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…n#5045)

* Added logging initial pose

Signed-off-by: Shintaro SAKODA <[email protected]>

* Added #include <string> to util_func.hpp

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…n#5045)

* Added logging initial pose

Signed-off-by: Shintaro SAKODA <[email protected]>

* Added #include <string> to util_func.hpp

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…n#5045)

* Added logging initial pose

Signed-off-by: Shintaro SAKODA <[email protected]>

* Added #include <string> to util_func.hpp

Signed-off-by: Shintaro SAKODA <[email protected]>

---------

Signed-off-by: Shintaro SAKODA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants