fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wep21
requested review from
satoshi-ota,
shmpwk and
tkimura4
as code owners
github-actions
bot
added
the
component:common
wep21
added
the
tag:run-build-and-test-differential
|
The base image for GitHub Actions is old and doesn't include the latest humble sync. |
3 tasks
This reverts commit 19ab508.
…2 geometry msgs Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
remove-redefinition-tf2-function
branch
from
c8d1865
to
da15a57
Compare
wep21
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
TakaHoribe,
takayuki5168,
purewater0901 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
This was referenced Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
==========================================
- Coverage 14.89% 14.88% -0.02%
==========================================
Files 1625 1625
Lines 112449 112434 -15
Branches 34712 34711 -1
==========================================
- Hits 16752 16737 -15
Misses 76959 76959
Partials 18738 18738
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
s-azumi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 27, 2023
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 27, 2023
Merged
4 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 27, 2023
#883) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]>
7 tasks
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 27, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]>
4 tasks
zhiwango
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
TakaHoribe
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
4 tasks
kazuki527
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
…2 geometry msgs (autowarefoundation#5089) (#887) Co-authored-by: Daisuke Nishimatsu <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 28, 2023
soblin
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 28, 2023
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 29, 2023
YoheiMishina
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 2, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Oct 4, 2023
taikitanaka3
pushed a commit
to taikitanaka3/autoware.universe
that referenced
this pull request
Oct 5, 2023
taikitanaka3
added a commit
that referenced
this pull request
Oct 5, 2023
…5232) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]>
This was referenced Oct 11, 2023
mergify bot
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]> (cherry picked from commit 1b231f3)
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 12, 2023
…2 geometry msgs (backport autowarefoundation#5089) (backport #884) (#933) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (backport autowarefoundation#5089) (#884) fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (autowarefoundation#5089) Co-authored-by: Daisuke Nishimatsu <[email protected]> (cherry picked from commit 1b231f3) Co-authored-by: Hiroki OTA <[email protected]>
oguzkaganozt
pushed a commit
to leo-drive/avte.autoware_universe
that referenced
this pull request
Oct 12, 2023
TetsuKawa
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 8, 2023
taikitanaka3
added a commit
that referenced
this pull request
Nov 20, 2023
* fix(autoware_auto_tf2): remove tf2 geometry function duplicated in tf2 geometry msgs (#5089) * fix(tier4_screen_capture_panel): set format date --------- Co-authored-by: Daisuke Nishimatsu <[email protected]>
s-azumi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
4 tasks
s-azumi
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…2 geometry msgs (autowarefoundation#5089) (#1038) Co-authored-by: Daisuke Nishimatsu <[email protected]>
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Feb 7, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove duplicated tf2 function introduced in this PR.
This causes build error as below.
This PR is necessary after next humble sync introduces tf2 geometry msgs 0.25.4.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.