-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ndt_scan_matcher): delete default parameters from ndt_scan_matcher_core.cpp #5155
refactor(ndt_scan_matcher): delete default parameters from ndt_scan_matcher_core.cpp #5155
Conversation
….cpp Extracted paramter map_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]>
Fixed minor grammar mistakes. Signed-off-by: TaikiYamada4 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
+ Coverage 14.85% 14.88% +0.02%
==========================================
Files 1627 1627
Lines 112673 112481 -192
Branches 34806 34723 -83
==========================================
+ Hits 16740 16741 +1
+ Misses 77173 76996 -177
+ Partials 18760 18744 -16
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: TaikiYamada4 <[email protected]>
…e defined in ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for creating the refactoring PR
…atcher_core.cpp (autowarefoundation#5155) * Removed default paramters in the constructor in ndt_scan_matcher_core.cpp Extracted paramter map_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> * Updated README.md to match ndt_scan_matcher.param.yaml Fixed minor grammar mistakes. Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * Fixed minor grammar mistakes Signed-off-by: TaikiYamada4 <[email protected]> * Removed unnecessary value initialization for parameters that should be defined in ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…atcher_core.cpp (autowarefoundation#5155) * Removed default paramters in the constructor in ndt_scan_matcher_core.cpp Extracted paramter map_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> * Updated README.md to match ndt_scan_matcher.param.yaml Fixed minor grammar mistakes. Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * Fixed minor grammar mistakes Signed-off-by: TaikiYamada4 <[email protected]> * Removed unnecessary value initialization for parameters that should be defined in ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…atcher_core.cpp (autowarefoundation#5155) * Removed default paramters in the constructor in ndt_scan_matcher_core.cpp Extracted paramter map_frame to ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> * Updated README.md to match ndt_scan_matcher.param.yaml Fixed minor grammar mistakes. Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix * style(pre-commit): autofix * Fixed minor grammar mistakes Signed-off-by: TaikiYamada4 <[email protected]> * Removed unnecessary value initialization for parameters that should be defined in ndt_scan_matcher.param.yaml Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Since there were still default values in the cpp code, which may occur unexpected results, I deleted them so that
ndt_scan_matcher
can get those value only fromndt_scan_matcher.param.yaml
.On this operation, parameter
map_frame
is extracted tondt_scan_matcher.param.yaml
.Plus, I updated
README.md
so that it matchesndt_scan_matcher.param.yaml
.Related: autowarefoundation/autoware_launch#596
Tests performed
It is able to build ndt_scan_matcher locally.
It is also confirmed that the logging_simulator on the tutorial works fine.
Effects on system behavior
This won't directly do something to the system.
It is expected to be less prone to unexpected behavior when parameter definitions are incomplete.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.