Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): keep distance against avoidable stationary objects #5236

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 5, 2023

Description

  • ego is in terminal current lanes
  • stationary object is in current lanes

-> keep distance against the object

image

  • ego is in terminal current lanes

-> keep lane change buffer to the terminal

image

  • ego is NOT in terminal current lanes
  • stationaly object is target lane

-> keep distance against the object

image

image

  • ego is NOT in terminal current lanes

-> keep lane change buffer to the terminal

image

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 5, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 5, 2023
@kosuke55 kosuke55 force-pushed the feat/lc_stop_distance branch 2 times, most recently from 280ffaa to 12dd1ce Compare October 5, 2023 15:43
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (b0310e7) 14.78% compared to head (230e705) 14.78%.
Report is 18 commits behind head on main.

❗ Current head 230e705 differs from pull request most recent head e666058. Consider uploading reports for the commit e666058 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5236    +/-   ##
========================================
  Coverage   14.78%   14.78%            
========================================
  Files        1648     1648            
  Lines      113963   114591   +628     
  Branches    35110    35562   +452     
========================================
+ Hits        16846    16941    +95     
- Misses      78177    78610   +433     
- Partials    18940    19040   +100     
Flag Coverage Δ *Carryforward flag
differential 12.40% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from b6c9bb2

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 4.09% <0.00%> (-0.38%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/lc_stop_distance branch 2 times, most recently from 55d07ef to 2cd2ede Compare October 6, 2023 04:55
Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
@TakaHoribe
Copy link
Contributor

The current implementation fails when executing lane change and avoidance simultaneously like in this case. The ego is avoiding the obstacle, but the lane change module stops the vehicle since the object in the current lane is recognized as a blocker.
image

Now the implementation is improved to check only the objects around the ego path.

Test case 1
image

Test case 2
image

Test case 3
image

Test case 4
image

@TakaHoribe
Copy link
Contributor

TakaHoribe commented Oct 11, 2023

Current implementation fails in this situation
image

Signed-off-by: Takamasa Horibe <[email protected]>
@TakaHoribe TakaHoribe merged commit 7e0ee1e into main Oct 12, 2023
23 of 25 checks passed
@TakaHoribe TakaHoribe deleted the feat/lc_stop_distance branch October 12, 2023 02:49
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
…autowarefoundation#5236)

* feat(lane_change): keep distance against avoidable stationary objects

Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>

* fix dangling

Signed-off-by: Takamasa Horibe <[email protected]>

* use parameter for velocity_treshold

Signed-off-by: Takamasa Horibe <[email protected]>

* check object only on the ego path

Signed-off-by: Takamasa Horibe <[email protected]>

* fix

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
…autowarefoundation#5236)

* feat(lane_change): keep distance against avoidable stationary objects

Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>

* fix dangling

Signed-off-by: Takamasa Horibe <[email protected]>

* use parameter for velocity_treshold

Signed-off-by: Takamasa Horibe <[email protected]>

* check object only on the ego path

Signed-off-by: Takamasa Horibe <[email protected]>

* fix

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
…autowarefoundation#5236)

* feat(lane_change): keep distance against avoidable stationary objects

Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>

* fix dangling

Signed-off-by: Takamasa Horibe <[email protected]>

* use parameter for velocity_treshold

Signed-off-by: Takamasa Horibe <[email protected]>

* check object only on the ego path

Signed-off-by: Takamasa Horibe <[email protected]>

* fix

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
…autowarefoundation#5236)

* feat(lane_change): keep distance against avoidable stationary objects

Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>

* fix dangling

Signed-off-by: Takamasa Horibe <[email protected]>

* use parameter for velocity_treshold

Signed-off-by: Takamasa Horibe <[email protected]>

* check object only on the ego path

Signed-off-by: Takamasa Horibe <[email protected]>

* fix

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
…autowarefoundation#5236)

* feat(lane_change): keep distance against avoidable stationary objects

Signed-off-by: kosuke55 <[email protected]>

consider rss distance

Signed-off-by: kosuke55 <[email protected]>

tmp

Signed-off-by: kosuke55 <[email protected]>

* fix dangling

Signed-off-by: Takamasa Horibe <[email protected]>

* use parameter for velocity_treshold

Signed-off-by: Takamasa Horibe <[email protected]>

* check object only on the ego path

Signed-off-by: Takamasa Horibe <[email protected]>

* fix

Signed-off-by: Takamasa Horibe <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants