Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): add guard to neigibor lanelets #5245

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix(lane_change): add guard to neigibor lanelets #5245

merged 1 commit into from
Oct 10, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 6, 2023

Description

image

image

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 6, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e12817d) 14.78% compared to head (be685e7) 14.78%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5245   +/-   ##
=======================================
  Coverage   14.78%   14.78%           
=======================================
  Files        1648     1648           
  Lines      113963   113947   -16     
  Branches    35110    35099   -11     
=======================================
  Hits        16848    16848           
+ Misses      78177    78164   -13     
+ Partials    18938    18935    -3     
Flag Coverage Δ *Carryforward flag
differential 12.43% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from e12817d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 16.31% <ø> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...include/obstacle_cruise_planner/common_structs.hpp 8.69% <ø> (+0.09%) ⬆️
...lude/obstacle_cruise_planner/planner_interface.hpp 21.21% <ø> (+3.26%) ⬆️
planning/obstacle_cruise_planner/src/node.cpp 12.42% <ø> (+0.01%) ⬆️
.../obstacle_cruise_planner/src/planner_interface.cpp 6.21% <ø> (+0.01%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.46% <0.00%> (-0.01%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <0.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit adb4872 into main Oct 10, 2023
35 of 38 checks passed
@rej55 rej55 deleted the fix/lc_die branch October 10, 2023 09:01
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 12, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants