Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fixed debug visualization bug #5284

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

fixed lane change visualization not showing safe information during debugging.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 12, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (84995ec) 14.84% compared to head (ad8ab47) 14.83%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5284      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.02%     
==========================================
  Files        1649     1649              
  Lines      114166   114230      +64     
  Branches    35323    35357      +34     
==========================================
- Hits        16943    16941       -2     
- Misses      78102    78170      +68     
+ Partials    19121    19119       -2     
Flag Coverage Δ *Carryforward flag
differential 12.37% <0.00%> (?)
total 14.84% <ø> (+<0.01%) ⬆️ Carriedforward from 84995ec

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.28% <ø> (+0.05%) ⬆️
...lude/obstacle_avoidance_planner/common_structs.hpp 55.88% <ø> (-1.27%) ⬇️
...lanner/include/obstacle_avoidance_planner/node.hpp 60.00% <ø> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 39.11% <ø> (+0.26%) ⬆️
planning/obstacle_cruise_planner/src/node.cpp 12.42% <ø> (+0.01%) ⬆️
...top_planner/include/obstacle_stop_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_stop_planner/src/node.cpp 9.33% <ø> (ø)
..._smoother/include/path_smoother/common_structs.hpp 41.17% <ø> (-1.69%) ⬇️
...er/include/path_smoother/elastic_band_smoother.hpp 60.00% <ø> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 02eb843 into autowarefoundation:main Oct 12, 2023
30 of 33 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lc-debug-not-printing branch October 12, 2023 08:22
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
TakaHoribe pushed a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants