Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): add debug log #5308

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Oct 13, 2023

Description

Add debug log in lane change

Related links

None

Tests performed

Run psim

image

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe enabled auto-merge (squash) October 13, 2023 11:46
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Oct 13, 2023
@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 13, 2023
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (5d6449d) 14.80% compared to head (e8e6db6) 14.80%.

❗ Current head e8e6db6 differs from pull request most recent head f0876a1. Consider uploading reports for the commit f0876a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5308      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1665     1665              
  Lines      115266   115295      +29     
  Branches    35578    35600      +22     
==========================================
+ Hits        17069    17070       +1     
- Misses      78937    78966      +29     
+ Partials    19260    19259       -1     
Flag Coverage Δ *Carryforward flag
differential 12.44% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 5d6449d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 15.21% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 50.00% <ø> (+50.00%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 3.88% <0.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takamasa Horibe <[email protected]>

update

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
@TakaHoribe TakaHoribe merged commit 95e8f21 into autowarefoundation:main Oct 16, 2023
21 of 22 checks passed
@TakaHoribe TakaHoribe deleted the lc-debug-log branch October 16, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants