Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix filtering objects #5317

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(lane_change): fix filtering objects #5317

merged 1 commit into from
Oct 16, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 16, 2023

Description

the lane fitering objects is wrong when disabling some target objects. (pedestrian: false)
(like yellow cube is current lane onjects)

before

image

after

image

Related links

Tests performed

psim

evaluator_description: fix/lc_filtering_obj
2023/10/16 https://evaluation.tier4.jp/evaluation/reports/5a16a7c8-04fb-5a3c-801d-9dcd2028e82c/?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 16, 2023
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 16, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (5d6449d) 14.80% compared to head (4643c49) 14.80%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5317      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1665     1665              
  Lines      115266   115294      +28     
  Branches    35578    35600      +22     
==========================================
+ Hits        17069    17070       +1     
- Misses      78937    78965      +28     
+ Partials    19260    19259       -1     
Flag Coverage Δ *Carryforward flag
differential 12.52% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 5d6449d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 15.21% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 50.00% <ø> (+50.00%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 3.88% <0.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit 78d4d82 into main Oct 16, 2023
39 of 42 checks passed
@rej55 rej55 deleted the fix/lc_filtering_obj branch October 16, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants