Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): do not use reference values of polygon outer #5318

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Oct 16, 2023

Description

Do not use reference values of polygon outer.

Related links

Tests performed

planning simulator

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 16, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 16, 2023
@rej55 rej55 enabled auto-merge (squash) October 16, 2023 07:18
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5725c2d) 14.80% compared to head (130769d) 14.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5318   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1665     1665           
  Lines      115286   115286           
  Branches    35600    35604    +4     
=======================================
  Hits        17068    17068           
  Misses      78958    78958           
  Partials    19260    19260           
Flag Coverage Δ *Carryforward flag
differential 12.52% <20.00%> (?)
total 14.80% <ø> (-0.01%) ⬇️ Carriedforward from 5725c2d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 3.92% <0.00%> (ø)
...ner/src/utils/path_safety_checker/safety_check.cpp 21.96% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit dad4722 into autowarefoundation:main Oct 16, 2023
31 of 33 checks passed
@rej55 rej55 deleted the fix/copy_polygon_outer branch October 16, 2023 09:21
rej55 added a commit to tier4/autoware.universe that referenced this pull request Oct 16, 2023
…arefoundation#5318)

* fix(lane_change): do not use refelence values of polygon outer

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): fix in lane change

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants