Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix avoidance return dead point calculation logic for high curverture path #5489

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 6, 2023

Description

🤖 Generated by Copilot at 84adaf6

Adjust the stop line distance for the avoidance path in avoidance_module.cpp. This prevents the vehicle from overshooting the stop line due to the shifted path curvature.

related ticket: https://tier4.atlassian.net/browse/RT1-4125


The avoidance module inserts a stop point in order not to pass through dead line to return original path. The return point is generated on original path, and the stop point is inserted on shifted path.

Therefore, it has to take the difference of distance between inner and outer path distance caused by high curverture into consideration. In this PR, it calculates the difference and set a stop point proper position.

image

Tests performed

simplescreenrecorder-2023-11-06_14.14.26.mp4

Effects on system behavior

Improve avoidance maneuver.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 6, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review November 6, 2023 10:43
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 7, 2023 07:37
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e628971) 14.85% compared to head (84adaf6) 14.87%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5489      +/-   ##
==========================================
+ Coverage   14.85%   14.87%   +0.02%     
==========================================
  Files        1669     1670       +1     
  Lines      116318   117149     +831     
  Branches    36266    36869     +603     
==========================================
+ Hits        17277    17427     +150     
- Misses      79535    80078     +543     
- Partials    19506    19644     +138     
Flag Coverage Δ *Carryforward flag
differential 12.14% <0.00%> (?)
total 14.85% <ø> (+<0.01%) ⬆️ Carriedforward from e628971

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 12.13% <0.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 338e1e4 into autowarefoundation:main Nov 7, 2023
52 of 54 checks passed
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 9, 2023
@satoshi-ota satoshi-ota deleted the fix/avoidance-return-point branch November 26, 2023 07:04
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Dec 8, 2023
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Dec 8, 2023
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants