refactor(obstacle_collision_checker): rework parameters #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karishma1911
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:control
satoshi-ota
changed the title
karishma1911
force-pushed
the
obstacle_collision_checker
branch
from
2e8f7c5
to
70cabf8
Compare
satoshi-ota
added
the
tag:run-build-and-test-differential
satoshi-ota
approved these changes
Nov 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5654 +/- ##
==========================================
- Coverage 15.32% 7.48% -7.85%
==========================================
Files 1721 4 -1717
Lines 118559 254 -118305
Branches 37995 138 -37857
==========================================
- Hits 18169 19 -18150
+ Misses 79657 227 -79430
+ Partials 20733 8 -20725
☔ View full report in Codecov by Sentry. |
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
obstacle_collision_checker
branch
from
70cabf8
to
d3965e3
Compare
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…dation#5654) Update-parameters-obstacle-collision-checker Signed-off-by: karishma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the obstacle_collision_checker..
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.