Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): add debugger output processing_time/cyclic_time/elapsed_time, tentative objects #5762

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 4, 2023

Description

🤖[deprecated] Generated by Copilot at 208708c

Improved the MultiObjectTracker node with debugging and performance measurement features. The code uses tier4_autoware_utils to publish metrics and tentative objects, and filters out unstable objects from the output. The changes affect multi_object_tracker_core.hpp and multi_object_tracker_core.cpp.

image

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested a review from miursh December 4, 2023 06:22
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 4, 2023
@YoshiRi YoshiRi marked this pull request as ready for review December 4, 2023 06:40
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Dec 4, 2023

data observation

With rosbag replay simulation, there are large difference between outputs with/without delay_compensation flag.

  • delay compensate: true
    image

  • delay compensate: false
    image

with publish speed to 1.0

Here is the sample output:

image

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (14bd929) 0.00%.
Report is 184 commits behind head on main.

Files Patch % Lines
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5762       +/-   ##
==========================================
- Coverage   15.32%   0.00%   -15.33%     
==========================================
  Files        1721      24     -1697     
  Lines      118559    1615   -116944     
  Branches    37995       0    -37995     
==========================================
- Hits        18169       0    -18169     
+ Misses      79657    1615    -78042     
+ Partials    20733       0    -20733     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit e58eac5 into autowarefoundation:main Dec 11, 2023
24 of 27 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…c_time/elapsed_time, tentative objects (autowarefoundation#5762)

* enable debugger in tracker

Signed-off-by: yoshiri <[email protected]>

* fix uninitialized class variable

Signed-off-by: yoshiri <[email protected]>

* feat: separate debugger class for simplification

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants