fix(start_planner): check safety only when waiting approval

[kyoichi-sugahara]

Description

Fix PR for the PR

1. The updateData() function now sets status_.is_safe_dynamic_objects to true when requiresDynamicObjectsCollisionDetection() returns false.

2. The isExecutionReady() function now checks for dynamic object collisions only if requiresDynamicObjectsCollisionDetection() returns true and isWaitingApproval() also returns true. This change ensures that dynamic object collision detection is performed only when necessary and approval is pending.

Tests performed

• PASS TIERIV INTERNAL SCENARIOS

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 793 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (566088c) 10.24%.
Report is 166 commits behind head on main.

Files	Patch %	Lines
.../scene_module/goal_planner/goal_planner_module.cpp	0.58%	168 Missing and 2 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp	10.48%	111 Missing and 17 partials ⚠️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp	1.88%	99 Missing and 5 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp	22.77%	68 Missing and 10 partials ⚠️
..._path_planner/src/marker_utils/avoidance/debug.cpp	0.00%	61 Missing ⚠️
...ath_planner/src/scene_module/avoidance/manager.cpp	18.86%	0 Missing and 43 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp	0.00%	28 Missing ⚠️
...ner/src/scene_module/dynamic_avoidance/manager.cpp	20.68%	4 Missing and 19 partials ⚠️
..._planner/src/scene_module/goal_planner/manager.cpp	11.53%	2 Missing and 21 partials ⚠️
...planner/src/scene_module/start_planner/manager.cpp	11.53%	6 Missing and 17 partials ⚠️
... and 19 more

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5792       +/-   ##
===========================================
- Coverage   15.32%   10.24%    -5.08%     
===========================================
  Files        1721       80     -1641     
  Lines      118559    11106   -107453     
  Branches    37995     6215    -31780     
===========================================
- Hits        18169     1138    -17031     
+ Misses      79657     7804    -71853     
+ Partials    20733     2164    -18569     

Flag	Coverage Δ
differential	10.24% <14.36%> (?)
total	?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.