Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix unexpected sudden deceleration for avoidance maneuver #5805

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 7, 2023

Description

🤖[deprecated] Generated by Copilot at b05ede1

Improved the path avoidance module by adjusting the deceleration point condition with a buffer speed parameter. This reduces unnecessary braking and allows tuning the driving behavior.

Tests performed

Psim

Effects on system behavior

Improve comfortablity

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 7, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 15, 2023 01:43
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1f82854) 15.35% compared to head (b05ede1) 15.35%.
Report is 4 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5805   +/-   ##
=======================================
  Coverage   15.35%   15.35%           
=======================================
  Files        1747     1747           
  Lines      120058   120058           
  Branches    36539    36539           
=======================================
  Hits        18439    18439           
  Misses      80962    80962           
  Partials    20657    20657           
Flag Coverage Δ *Carryforward flag
differential 13.36% <0.00%> (?)
total 15.35% <ø> (+<0.01%) ⬆️ Carriedforward from 1f82854

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 88dae03 into autowarefoundation:main Dec 15, 2023
38 of 40 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-sudden-decel branch December 15, 2023 09:44
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…uver (autowarefoundation#5805)

fix(avoidance): fix sudden deceleration

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…uver (autowarefoundation#5805)

fix(avoidance): fix sudden deceleration

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…uver (autowarefoundation#5805)

fix(avoidance): fix sudden deceleration

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…uver (autowarefoundation#5805)

fix(avoidance): fix sudden deceleration

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…uver (autowarefoundation#5805)

fix(avoidance): fix sudden deceleration

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants