Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): delete unnecessary TODO #5806

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

remove unnecessary TODO
TRYING status doesn't exist anymore

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 7, 2023
@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1958 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (3427f3c) 8.79%.
Report is 173 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/scene.cpp 13.04% 561 Missing and 92 partials ⚠️
...path_avoidance_module/src/shift_line_generator.cpp 12.99% 443 Missing and 66 partials ⚠️
...nning/behavior_path_avoidance_module/src/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 188 Missing ⚠️
...th_avoidance_by_lane_change_module/src/manager.cpp 17.70% 0 Missing and 79 partials ⚠️
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 61 Missing ⚠️
...ing/behavior_path_avoidance_module/src/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 25.53% 0 Missing and 35 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 26.08% 0 Missing and 34 partials ⚠️
..._planner_module/src/default_fixed_goal_planner.cpp 0.00% 34 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5806       +/-   ##
==========================================
- Coverage   15.32%   8.79%    -6.53%     
==========================================
  Files        1721      83     -1638     
  Lines      118559   10926   -107633     
  Branches    37995    4424    -33571     
==========================================
- Hits        18169     961    -17208     
+ Misses      79657    8266    -71391     
+ Partials    20733    1699    -19034     
Flag Coverage Δ
differential 8.79% <12.47%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit 566c57f into autowarefoundation:main Dec 7, 2023
30 of 33 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/remove_unnecessary_TODO branch December 7, 2023 12:47
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ndation#5806)

delete unnecessary TODO

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…ndation#5806)

delete unnecessary TODO

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants