Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing param on perception launch: #5812

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Dec 8, 2023

detection_by_tracker_param_path was missing

Description

A missing parameter detection_by_tracker_param_path on perception launch files is added.
The configuration is aligned with the tier4 autoware.universe.

Tests performed

The system launch in a tier4 recompute environment.

Effects on system behavior

The perception module can be launched appropriately.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 8, 2023
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin enabled auto-merge (squash) December 8, 2023 03:53
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin force-pushed the fix/perc_launch_missing_param_detect_by_track branch from a6c44ab to 56a067e Compare December 8, 2023 04:01
@technolojin technolojin enabled auto-merge (squash) December 8, 2023 04:20
@YoshiRi YoshiRi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
@technolojin technolojin merged commit 1bac0bf into autowarefoundation:main Dec 8, 2023
31 checks passed
@technolojin technolojin deleted the fix/perc_launch_missing_param_detect_by_track branch December 8, 2023 07:56
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
detection_by_tracker_param_path was missing

Signed-off-by: Taekjin LEE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants