Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(raw_vehicle_cmd_converter): update readme #5822

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Dec 8, 2023

Description

Update readme for the accel-brake-map used in the raw_vehicle_cmd_converter

Tests performed

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Dec 8, 2023
@TakaHoribe TakaHoribe added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (d7ee435) 10.52%.
Report is 181 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5822       +/-   ##
===========================================
- Coverage   15.32%   10.52%    -4.81%     
===========================================
  Files        1721       14     -1707     
  Lines      118559     1416   -117143     
  Branches    37995      166    -37829     
===========================================
- Hits        18169      149    -18020     
+ Misses      79657     1126    -78531     
+ Partials    20733      141    -20592     
Flag Coverage Δ
differential 10.52% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 7faeb91 into autowarefoundation:main Dec 19, 2023
43 of 45 checks passed
@TakaHoribe TakaHoribe deleted the update-readme-acc-map branch December 19, 2023 05:04
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants