feat(crosswalk): ignore predicted path going across the crosswalk #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
7 tasks
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
fix/crosswalk-predicted-path-direction
branch
from
4157406
to
4d162cc
Compare
soblin
requested review from
kyoichi-sugahara,
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
yuki-takagi-66
requested changes
Dec 12, 2023
planning/behavior_velocity_crosswalk_module/config/crosswalk.param.yaml
Outdated
Show resolved
Hide resolved
|
Case 2 video after this PR still seems to be uploading now ...? |
…ate direction along vehicle lane. check the type Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
yuki-takagi-66
approved these changes
Dec 14, 2023
soblin
added
the
tag:run-build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5849 +/- ##
==========================================
+ Coverage 15.27% 15.29% +0.01%
==========================================
Files 1739 1739
Lines 119820 119946 +126
Branches 36377 36447 +70
==========================================
+ Hits 18306 18346 +40
- Misses 81030 81091 +61
- Partials 20484 20509 +25
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: karishma <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…towarefoundation#5849) Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed to ignore the predicted path that crosses the crosswalk in almost the same direction as ego vehicle.
launcher PR: autowarefoundation/autoware_launch#733
Related links
https://tier4.atlassian.net/browse/RT1-3967
Tests performed
https://evaluation.tier4.jp/evaluation/reports/8acb8fe9-6f94-5427-8bbe-58b7914b1d4c?project_id=prd_jt
RT1-3967-1-2023-12-12_17.53.13.mp4
case2
RT1-3967-1-2023-12-12_17.58.19.mp4
after this PR
crosswalk stopline does not appear
case1
RT1-3967-1-2023-12-14_17.01.02.mp4
case2
RT1-3967-1-2023-12-14_17.03.47.mp4
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.