Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity): clear values before adding partition #590

Conversation

taikitanaka3
Copy link
Contributor

Description

clear duplicated values in vector

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 requested a review from 0x126 March 28, 2022 04:30
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 changed the title fix(behavior_velocity): clear values before adding partition fix(behavior_velocity): clear values before adding partition Mar 28, 2022
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) March 28, 2022 04:40
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #590 (56bbb9b) into main (0abf13a) will decrease coverage by 5.06%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main    #590      +/-   ##
=========================================
- Coverage   10.88%   5.82%   -5.07%     
=========================================
  Files         706      68     -638     
  Lines       50006    5050   -44956     
  Branches     6579     552    -6027     
=========================================
- Hits         5443     294    -5149     
+ Misses      40156    4593   -35563     
+ Partials     4407     163    -4244     
Impacted Files Coverage Δ
...behavior_velocity_planner/src/utilization/util.cpp 26.63% <ø> (ø)
...t2_extension/test/src/test_regulatory_elements.cpp
...r4_planning_rviz_plugin/src/trajectory/display.cpp
localization/stop_filter/src/stop_filter.cpp
...t_tracker/src/tracker/model/pedestrian_tracker.cpp
...r_nodes/test/test_longitudinal_controller_node.cpp
.../euclidean_cluster/euclidean_cluster_interface.hpp
...rough_filter/passthrough_filter_uint16_nodelet.cpp
...nclude/topic_state_monitor/topic_state_monitor.hpp
...rger/src/object_association_merger/utils/utils.cpp
... and 629 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0abf13a...56bbb9b. Read the comment docs.

@taikitanaka3 taikitanaka3 merged commit 21a3037 into autowarefoundation:main Mar 28, 2022
@taikitanaka3 taikitanaka3 deleted the fix-behavior-velocity-extract-close-partition branch March 29, 2022 00:25
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request May 16, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants