Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): disable stuck detection against private lane #5910

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Dec 19, 2023

Description

disable stuck vehicle detection against private lane

launcher PR: autowarefoundation/autoware_launch#744

Related links

Tests performed

before

image

after

Screenshot from 2023-12-19 14-03-39

Notes for reviewers

Interface changes

none.\

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2023
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 19, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (320bc2f) 15.29% compared to head (40734e9) 15.29%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 4 Missing ⚠️
...avior_velocity_intersection_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5910   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1747     1747           
  Lines      120208   120206    -2     
  Branches    36631    36630    -1     
=======================================
  Hits        18383    18383           
  Misses      81207    81207           
+ Partials    20618    20616    -2     
Flag Coverage Δ *Carryforward flag
differential 5.25% <0.00%> (?)
total 15.29% <ø> (+<0.01%) ⬆️ Carriedforward from 320bc2f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 9761d21 into autowarefoundation:main Dec 20, 2023
34 of 38 checks passed
@soblin soblin deleted the fix/intersection/private-stuck-cond branch December 20, 2023 04:01
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 20, 2023
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants