Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landmark_manager): add get_landmarrks func #6063

Conversation

YamatoAndo
Copy link
Contributor

Description

A function has been added to return an array of landmarks in the landmark_manager.
This function is intended to be used in the lidar_marker_localizer for searching the nearest landmark and so on.

Tests performed

LSim works.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yamato-ando <Yamato ANDO>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jan 12, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@YamatoAndo YamatoAndo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b51759f) 14.65% compared to head (f09952d) 14.64%.

Files Patch % Lines
...ocalizer/landmark_manager/src/landmark_manager.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6063      +/-   ##
==========================================
- Coverage   14.65%   14.64%   -0.01%     
==========================================
  Files        1857     1858       +1     
  Lines      126512   126520       +8     
  Branches    37059    37063       +4     
==========================================
  Hits        18535    18535              
- Misses      87154    87162       +8     
  Partials    20823    20823              
Flag Coverage Δ *Carryforward flag
differential 5.61% <0.00%> (?)
total 14.65% <ø> (ø) Carriedforward from b51759f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit d1a86e6 into autowarefoundation:main Jan 12, 2024
31 of 33 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
)

Signed-off-by: yamato-ando <Yamato ANDO>
Co-authored-by: yamato-ando <Yamato ANDO>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants