Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vehicle_info): add docs for versioning #6069

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 14, 2024

Description

update vehicle info docs based on https://github.com/orgs/autowarefoundation/discussions/4050

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review January 14, 2024 06:00
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jan 14, 2024
Signed-off-by: kosuke55 <[email protected]>

remove non-support

Signed-off-by: kosuke55 <[email protected]>

fix link

Signed-off-by: kosuke55 <[email protected]>

add yaml

Signed-off-by: kosuke55 <[email protected]>

please check readme
@shmpwk shmpwk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39642d2) 14.65% compared to head (fa031d8) 14.65%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6069   +/-   ##
=======================================
  Coverage   14.65%   14.65%           
=======================================
  Files        1858     1858           
  Lines      126455   126455           
  Branches    37063    37063           
=======================================
+ Hits        18535    18536    +1     
  Misses      87097    87097           
+ Partials    20823    20822    -1     
Flag Coverage Δ *Carryforward flag
differential 18.32% <ø> (?)
total 14.65% <ø> (ø) Carriedforward from 39642d2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor Author

@mitsudome-r @xmfcx
If this looks good for you, I'll merge it.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor Author

kosuke55 commented Jan 18, 2024

@xmfcx
I'll merge this. If you have any concerns, please let me know 🙏

@kosuke55 kosuke55 merged commit c833bea into autowarefoundation:main Jan 18, 2024
32 of 34 checks passed
@kosuke55 kosuke55 deleted the docs/vehicle_info_version branch January 18, 2024 09:51
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
Signed-off-by: kosuke55 <[email protected]>

remove non-support

Signed-off-by: kosuke55 <[email protected]>

fix link

Signed-off-by: kosuke55 <[email protected]>

add yaml

Signed-off-by: kosuke55 <[email protected]>

please check readme
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Signed-off-by: kosuke55 <[email protected]>

remove non-support

Signed-off-by: kosuke55 <[email protected]>

fix link

Signed-off-by: kosuke55 <[email protected]>

add yaml

Signed-off-by: kosuke55 <[email protected]>

please check readme

Signed-off-by: karishma <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Signed-off-by: kosuke55 <[email protected]>

remove non-support

Signed-off-by: kosuke55 <[email protected]>

fix link

Signed-off-by: kosuke55 <[email protected]>

add yaml

Signed-off-by: kosuke55 <[email protected]>

please check readme
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: kosuke55 <[email protected]>

remove non-support

Signed-off-by: kosuke55 <[email protected]>

fix link

Signed-off-by: kosuke55 <[email protected]>

add yaml

Signed-off-by: kosuke55 <[email protected]>

please check readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants