Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): re-organize the parameters for image projection fusion #6075

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jan 15, 2024

Description

Re-organize the image_projection_based_fusion parameters defined in launch files

Related links

autowarefoundation/autoware_launch#789

Tests performed

Confirmed with logging_simulator.launch.xml

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 15, 2024
@miursh miursh changed the title re-organize the parameters for image projection fusion feat(image_projection_based_fusion): re-organize the parameters for image projection fusion Jan 15, 2024
@miursh miursh changed the title feat(image_projection_based_fusion): re-organize the parameters for image projection fusion fix(image_projection_based_fusion): re-organize the parameters for image projection fusion Jan 15, 2024
@miursh miursh requested a review from kminoda January 15, 2024 05:59
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 15, 2024
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 6e550fc into main Jan 15, 2024
40 of 42 checks passed
@miursh miursh deleted the fix/image_proj_fusion_param_path branch January 15, 2024 15:09
kminoda pushed a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
kminoda added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2024
…age projection fusion (autowarefoundation#6075) (#1101)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Jan 22, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Jan 22, 2024
…age projection fusion (autowarefoundation#6075) (#1109)

fix(image_projection_based_fusion): re-organize the parameters for image projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…age projection fusion (autowarefoundation#6075)

re-organize the parameters for image projection fusion

Signed-off-by: Shunsuke Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants