-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(image_projection_based_fusion): re-organize the parameters for image projection fusion #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Miura <[email protected]>
7 tasks
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jan 15, 2024
miursh
changed the title
re-organize the parameters for image projection fusion
feat(image_projection_based_fusion): re-organize the parameters for image projection fusion
Jan 15, 2024
miursh
changed the title
feat(image_projection_based_fusion): re-organize the parameters for image projection fusion
fix(image_projection_based_fusion): re-organize the parameters for image projection fusion
Jan 15, 2024
kminoda
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 15, 2024
badai-nguyen
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kminoda
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 18, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
4 tasks
kminoda
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 18, 2024
…age projection fusion (autowarefoundation#6075) (#1101) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]>
badai-nguyen
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 22, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
4 tasks
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 22, 2024
…age projection fusion (autowarefoundation#6075) (#1109) fix(image_projection_based_fusion): re-organize the parameters for image projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…age projection fusion (autowarefoundation#6075) re-organize the parameters for image projection fusion Signed-off-by: Shunsuke Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-organize the image_projection_based_fusion parameters defined in launch files
Related links
autowarefoundation/autoware_launch#789
Tests performed
Confirmed with logging_simulator.launch.xml
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.