Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): remove duplicated execution condition #6087

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 16, 2024

Description

remove duplicated execution condition

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 16, 2024
@kosuke55 kosuke55 marked this pull request as ready for review January 16, 2024 05:38
@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3f8e0a) 14.62% compared to head (b217865) 14.62%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6087   +/-   ##
=======================================
  Coverage   14.62%   14.62%           
=======================================
  Files        1858     1858           
  Lines      127032   127028    -4     
  Branches    37214    37214           
=======================================
  Hits        18581    18581           
+ Misses      87554    87550    -4     
  Partials    20897    20897           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.62% <ø> (+<0.01%) ⬆️ Carriedforward from c3f8e0a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit e3d4e75 into main Jan 18, 2024
24 of 25 checks passed
@kosuke55 kosuke55 deleted the refactor/goal_planner branch January 18, 2024 02:10
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2024
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants