Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(planning): change params to vehicle tested values #6118

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 19, 2024

Description

change params to vehicle tested values

launch side: autowarefoundation/autoware_launch#797

Tests performed

Vehicle tests have been performed.
tier4 internal tests https://evaluation.tier4.jp/evaluation/reports/66872580-e421-5b93-9d03-45eadb92273f?project_id=prd_jt

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 19, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review January 19, 2024 07:13
@yuki-takagi-66 yuki-takagi-66 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2de78d) 14.60% compared to head (1e18eec) 14.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6118   +/-   ##
=======================================
  Coverage   14.60%   14.60%           
=======================================
  Files        1860     1860           
  Lines      127325   127325           
  Branches    37276    37276           
=======================================
  Hits        18598    18598           
  Misses      87810    87810           
  Partials    20917    20917           
Flag Coverage Δ *Carryforward flag
differential 10.25% <ø> (?)
total 14.60% <ø> (ø) Carriedforward from c2de78d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 57933b8 into autowarefoundation:main Jan 22, 2024
38 of 40 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the chore/planning/change-params-to-tested-values branch January 22, 2024 04:08
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants