-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(image_projection_based_fusion): rework parameters #6169
chore(image_projection_based_fusion): rework parameters #6169
Conversation
Signed-off-by: kminoda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
==========================================
- Coverage 14.93% 14.39% -0.55%
==========================================
Files 1817 1906 +89
Lines 125140 129797 +4657
Branches 37617 37519 -98
==========================================
- Hits 18695 18686 -9
- Misses 85435 90150 +4715
+ Partials 21010 20961 -49
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0f44c93
to
b8c980e
Compare
…ed_fusion/use_config
Signed-off-by: kminoda <[email protected]>
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <[email protected]> * docs: update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <[email protected]> * docs: update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ework chore(image_projection_based_fusion): rework parameters (autowarefoundation#6169)
…dation#6169) * chore(image_projection_based_fusion): use config Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * fix: revert build_only option Signed-off-by: kminoda <[email protected]> * docs: update readme Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * update component launcher as well Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Use param file for image_projection_based_fusion
Must be merged with autowarefoundation/autoware_launch#824
Tests performed
Launch Autoware and confirm that the parameters are loaded successfully.
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.