fix(motion_velocity_smoother): initialize params for dynamic parameter

[mkuri]

Description

Fix the bug caused by the following commit.
#609

• Member variables were not initialized for dynamically parameter settings

How to check

• Confirmation that each smoother can be used to run on the simulator

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #617 (4332a5f) into main (95414c5) will decrease coverage by 10.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #617       +/-   ##
==========================================
- Coverage   10.74%   0.00%   -10.75%     
==========================================
  Files         713      10      -703     
  Lines       50671    1776    -48895     
  Branches     6572       0     -6572     
==========================================
- Hits         5443       0     -5443     
+ Misses      40821    1776    -39045     
+ Partials     4407       0     -4407     

Impacted Files	Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp	0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp	0.00% <0.00%> (ø)
...y_smoother/src/smoother/jerk_filtered_smoother.cpp	0.00% <0.00%> (ø)
..._smoother/src/smoother/l2_pseudo_jerk_smoother.cpp	0.00% <0.00%> (ø)
...moother/src/smoother/linf_pseudo_jerk_smoother.cpp	0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp	0.00% <0.00%> (ø)
...e/interpolation/spline_interpolation_points_2d.hpp
localization/ndt/include/ndt/impl/pcl_modified.hpp
... and 701 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95414c5...4332a5f. Read the comment docs.

[taikitanaka3]

looks good in latest autoware.universe

[TakaHoribe]

@mkuri So, we can remove the parameter member variables managed in MotionVelocitySmootherNode class?

  SmootherBase::BaseParam base_param_{};
  JerkFilteredSmoother::Param jerk_filtered_smoother_param_{};
  L2PseudoJerkSmoother::Param l2_pseudo_jerk_smoother_param_{};
  LinfPseudoJerkSmoother::Param linf_pseudo_jerk_smoother_param_{};
  AnalyticalJerkConstrainedSmoother::Param analytical_jerk_constrained_smoother_param_{};

[mkuri]

@TakaHoribe
Those variables are used for dynamic parameter settings.

[mkuri]

@TakaHoribe
Those variables are changed from member variables to local variables.
And I confirmed that it is possible to change smoother parameters dynamically.

[TakaHoribe]

LGTM!