Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(intersection): add const to member functions, replace enum with class tag for occlusion #6299

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 4, 2024

Description

added const to member functions for readability

Tests performed

https://evaluation.tier4.jp/evaluation/reports/a40b1c77-0f2a-5017-95e8-f397bf4c3f25?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (0b90a97) 14.90% compared to head (01ea64a) 14.90%.
Report is 6 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 16 Missing ⚠️
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 5 Missing ⚠️
...ection_module/src/scene_intersection_collision.cpp 0.00% 2 Missing ⚠️
...elocity_intersection_module/src/object_manager.cpp 0.00% 1 Missing ⚠️
...ity_intersection_module/src/scene_intersection.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6299      +/-   ##
==========================================
- Coverage   14.90%   14.90%   -0.01%     
==========================================
  Files        1817     1817              
  Lines      125466   125471       +5     
  Branches    37706    37707       +1     
==========================================
  Hits        18699    18699              
- Misses      85751    85756       +5     
  Partials    21016    21016              
Flag Coverage Δ *Carryforward flag
differential 4.62% <0.00%> (?)
total 14.90% <ø> (+<0.01%) ⬆️ Carriedforward from 0b90a97

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin force-pushed the refactor/intersection/add-const branch from e01525a to 8ae2cd2 Compare February 5, 2024 01:55
@soblin soblin changed the title refactor(intersection): add const to member functions chore(intersection): add const to member functions Feb 6, 2024
@soblin soblin changed the title chore(intersection): add const to member functions chore(intersection): add const to member functions, replace enum with class tag for occlusion Feb 6, 2024
@soblin soblin force-pushed the refactor/intersection/add-const branch 2 times, most recently from 057a3fd to c5ff0ac Compare February 6, 2024 02:35
@soblin soblin force-pushed the refactor/intersection/add-const branch from c5ff0ac to 01ea64a Compare February 6, 2024 02:38
@soblin soblin marked this pull request as ready for review February 6, 2024 02:57
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 6, 2024
@soblin soblin merged commit 3a10282 into autowarefoundation:main Feb 7, 2024
32 of 36 checks passed
@soblin soblin deleted the refactor/intersection/add-const branch February 7, 2024 08:22
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants