Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hazard_status_converter): add package #6428

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 15, 2024

Description

https://github.com/orgs/autowarefoundation/discussions/4176
This change removes system_error_monitor and /hazard_status is no longer output, so add a conversion node for compatibility.

Note: This node was first implemented in https://github.com/tier4/autoware.universe. Therefore, the publication year of the copyright is 2023.

Tests performed

  1. Run this command
    ros2 launch diagnostic_graph_aggregator example.launch.xml
  2. Run this command in other terminal
    ros2 launch hazard_status_converter hazard_status_converter.launch.xml
  3. Check if hazard status is output.
    ros2 topic echo /hazard_status

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
…i/autoware.universe into feat/hazard-status-converter
@isamu-takagi isamu-takagi self-assigned this Feb 15, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Feb 15, 2024
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 20, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 20, 2024 12:18
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 20, 2024 12:18
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (c9e6dda) 14.99% compared to head (cadabaa) 14.99%.
Report is 42 commits behind head on main.

Files Patch % Lines
system/hazard_status_converter/src/converter.cpp 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6428      +/-   ##
==========================================
- Coverage   14.99%   14.99%   -0.01%     
==========================================
  Files        1838     1839       +1     
  Lines      127099   127121      +22     
  Branches    38075    38065      -10     
==========================================
  Hits        19062    19062              
- Misses      86715    86737      +22     
  Partials    21322    21322              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.00% <ø> (+<0.01%) ⬆️ Carriedforward from c9e6dda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 5d17128 into autowarefoundation:main Feb 20, 2024
36 of 38 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 13, 2024
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 20, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants