feat(lidar_centerpoint): remove files those are no longer supported nor used #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or used Signed-off-by: kminoda <[email protected]>
github-actions
bot
added
type:documentation
kminoda
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6497 +/- ##
==========================================
+ Coverage 14.77% 14.79% +0.02%
==========================================
Files 1917 1917
Lines 132319 132097 -222
Branches 39298 39248 -50
==========================================
- Hits 19552 19548 -4
+ Misses 90941 90733 -208
+ Partials 21826 21816 -10
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@knzo25 Ping |
knzo25
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks for handling the issue.
There was only a header file I think should also be deleted.
By the way, the guys that did the TVM implementation copied the inference node and the visualization script. Is that in the scope of things that should be deleted?
https://github.com/autowarefoundation/autoware.universe/tree/main/perception/lidar_centerpoint_tvm
(I can send the PR later)
Signed-off-by: kminoda <[email protected]>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…or used (#6497) * feat(lidar_centerpoint): remove files those are no longer supported nor used Signed-off-by: kminoda <[email protected]> * remove unnecessary file Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…or used (autowarefoundation#6497) * feat(lidar_centerpoint): remove files those are no longer supported nor used Signed-off-by: kminoda <[email protected]> * remove unnecessary file Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: kaigohirao <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…or used (autowarefoundation#6497) * feat(lidar_centerpoint): remove files those are no longer supported nor used Signed-off-by: kminoda <[email protected]> * remove unnecessary file Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused files that are no longer supported
autowarefoundation/autoware#4165
Tests performed
Confirmed that build for the package succeeds and Autoware logging_simulator works fine with successful perception output.
Effects on system behavior
None
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.