Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler, emergency_handler): remove takeover #6522

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Mar 1, 2024

Description

Remove takeover functions.
See #2994 for more detail.

Tests performed

Confirmed MRM changes from (NORMAL, NODE) to (OPERATING, EMERGENCY_STOP) in Psim.
Confirmed MRM changes from (OPERATING, EMERGENCY_STOP) to (NORMAL, NODE) in Psim.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@veqcc veqcc requested a review from mkuri as a code owner March 1, 2024 01:02
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Mar 1, 2024
@veqcc veqcc requested a review from TetsuKawa March 1, 2024 01:02
@veqcc veqcc self-assigned this Mar 1, 2024
@veqcc veqcc changed the title update(mrm_handler, emergency_handler): remove takeover feat(mrm_handler, emergency_handler): remove takeover Mar 4, 2024
@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 14.81%. Comparing base (59f7031) to head (cd7c049).
Report is 4 commits behind head on main.

Files Patch % Lines
...r/src/emergency_handler/emergency_handler_core.cpp 0.00% 3 Missing ⚠️
...m/mrm_handler/src/mrm_handler/mrm_handler_core.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6522      +/-   ##
==========================================
+ Coverage   14.78%   14.81%   +0.03%     
==========================================
  Files        1917     1917              
  Lines      132038   131746     -292     
  Branches    39228    39187      -41     
==========================================
  Hits        19523    19523              
+ Misses      90726    90441     -285     
+ Partials    21789    21782       -7     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.81% <ø> (+0.03%) ⬆️ Carriedforward from 55c10e2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 888fec6 into autowarefoundation:main Mar 6, 2024
23 of 24 checks passed
@veqcc veqcc deleted the update_mrm_handler branch March 6, 2024 07:12
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
update(mrm_handler, emergency_handler): remove takeover

Signed-off-by: veqcc <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…tion#6522)

update(mrm_handler, emergency_handler): remove takeover

Signed-off-by: veqcc <[email protected]>
Signed-off-by: kaigohirao <[email protected]>
mkuri pushed a commit to tier4/autoware.universe that referenced this pull request Mar 28, 2024
…tion#6522)

update(mrm_handler, emergency_handler): remove takeover

Signed-off-by: veqcc <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#6522)

update(mrm_handler, emergency_handler): remove takeover

Signed-off-by: veqcc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants