-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(control/pid_longitudinal_controller): rework parameters #6707
Conversation
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6707/ |
ef911b8
to
b8e1e3b
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
1521f04
to
3865866
Compare
@oguzkaganozt |
0deada8
to
04de8f2
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Working on it :) |
da8333e
to
2988d5f
Compare
2988d5f
to
faabfd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
faabfd7
to
4e57762
Compare
4e57762
to
80de550
Compare
Signed-off-by: Oguz <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
80de550
to
9f5fe7e
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
=======================================
Coverage 23.93% 23.93%
=======================================
Files 1382 1382
Lines 102001 101976 -25
Branches 38868 38851 -17
=======================================
+ Hits 24410 24411 +1
+ Misses 75124 75097 -27
- Partials 2467 2468 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@oguzkaganozt |
…owarefoundation#6707) * reset and re-apply refactoring Signed-off-by: Oguz <[email protected]> * style(pre-commit): autofix * . Signed-off-by: Oguz Ozturk <[email protected]> * . Signed-off-by: Oguz Ozturk <[email protected]> --------- Signed-off-by: Oguz <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…owarefoundation#6707) * reset and re-apply refactoring Signed-off-by: Oguz <[email protected]> * style(pre-commit): autofix * . Signed-off-by: Oguz Ozturk <[email protected]> * . Signed-off-by: Oguz Ozturk <[email protected]> --------- Signed-off-by: Oguz <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…owarefoundation#6707) * reset and re-apply refactoring Signed-off-by: Oguz <[email protected]> * style(pre-commit): autofix * . Signed-off-by: Oguz Ozturk <[email protected]> * . Signed-off-by: Oguz Ozturk <[email protected]> --------- Signed-off-by: Oguz <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371
Tests performed
Built and launched the node locally.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.