refactor(control/pid_longitudinal_controller): rework parameters #6707

oguzkaganozt · 2024-03-28T12:29:57Z

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Built and launched the node locally.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

github-actions · 2024-04-03T14:52:35Z

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6707/
Modified URLs:

stale · 2024-06-04T01:22:42Z

This pull request has been automatically marked as stale because it has not had recent activity.

control/pid_longitudinal_controller/README.md

perception/tensorrt_yolox/launch/yolox.launch.xml

vividf · 2024-08-06T02:08:48Z

@oguzkaganozt
Would like to ask are you working on this PR :)
Thanks

github-actions · 2024-08-12T16:31:24Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

oguzkaganozt · 2024-08-12T16:37:51Z

@oguzkaganozt Would like to ask are you working on this PR :) Thanks

Working on it :)

oguzkaganozt · 2024-08-15T09:36:55Z

@TakaHoribe @takayuki5168 @soblin

takayuki5168

Thank you.

Signed-off-by: Oguz <[email protected]>

Signed-off-by: Oguz Ozturk <[email protected]>

codecov · 2024-08-21T13:48:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.93%. Comparing base (556816d) to head (797236d).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6707   +/-   ##
=======================================
  Coverage   23.93%   23.93%           
=======================================
  Files        1382     1382           
  Lines      102001   101976   -25     
  Branches    38868    38851   -17     
=======================================
+ Hits        24410    24411    +1     
+ Misses      75124    75097   -27     
- Partials     2467     2468    +1

Flag	Coverage Δ		*Carryforward flag
differential	`35.09% <ø> (?)`
total	`23.94% <ø> (+<0.01%)`	⬆️	Carriedforward from 556816d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuki-takagi-66 · 2024-08-26T09:32:34Z

@oguzkaganozt
The parameter stopped_jerk has recently been removed. It would be appreciated if you could support this.

…owarefoundation#6707) * reset and re-apply refactoring Signed-off-by: Oguz <[email protected]> * style(pre-commit): autofix * . Signed-off-by: Oguz Ozturk <[email protected]> * . Signed-off-by: Oguz Ozturk <[email protected]> --------- Signed-off-by: Oguz <[email protected]> Signed-off-by: Oguz Ozturk <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

oguzkaganozt requested review from soblin, TakaHoribe and takayuki5168 as code owners March 28, 2024 12:29

oguzkaganozt self-assigned this Mar 28, 2024

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Mar 28, 2024

oguzkaganozt marked this pull request as draft March 28, 2024 12:30

oguzkaganozt added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Apr 3, 2024

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from ef911b8 to b8e1e3b Compare April 3, 2024 15:11

oguzkaganozt marked this pull request as ready for review April 3, 2024 15:11

stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 4, 2024

mitsudome-r reviewed Jun 20, 2024

View reviewed changes

control/pid_longitudinal_controller/README.md Outdated Show resolved Hide resolved

stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jun 20, 2024

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from 1521f04 to 3865866 Compare June 21, 2024 12:46

oguzkaganozt requested review from dan-dnn and manato as code owners June 21, 2024 12:46

github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) and removed type:documentation Creating or refining documentation. (auto-assigned) labels Jun 21, 2024

oguzkaganozt requested a review from mitsudome-r June 21, 2024 12:50

mitsudome-r reviewed Jul 11, 2024

View reviewed changes

perception/tensorrt_yolox/launch/yolox.launch.xml Outdated Show resolved Hide resolved

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from 0deada8 to 04de8f2 Compare August 12, 2024 16:31

github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 12, 2024

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from da8333e to 2988d5f Compare August 12, 2024 16:38

oguzkaganozt requested a review from mitsudome-r August 12, 2024 16:38

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from 2988d5f to faabfd7 Compare August 15, 2024 09:35

takayuki5168 approved these changes Aug 20, 2024

View reviewed changes

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from faabfd7 to 4e57762 Compare August 20, 2024 11:57

oguzkaganozt enabled auto-merge (squash) August 20, 2024 11:58

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from 4e57762 to 80de550 Compare August 21, 2024 11:36

oguzkaganozt and others added 4 commits August 21, 2024 16:09

reset and re-apply refactoring

25791ff

Signed-off-by: Oguz <[email protected]>

style(pre-commit): autofix

7106fe1

.

0fcb553

Signed-off-by: Oguz Ozturk <[email protected]>

.

9f5fe7e

Signed-off-by: Oguz Ozturk <[email protected]>

oguzkaganozt force-pushed the refactor/pid_longitudinal_controller branch from 80de550 to 9f5fe7e Compare August 21, 2024 13:10

oguzkaganozt and others added 3 commits August 21, 2024 16:20

fix

1295a27

Signed-off-by: Oguz Ozturk <[email protected]>

.

05ad1e3

Signed-off-by: Oguz Ozturk <[email protected]>

style(pre-commit): autofix

797236d

oguzkaganozt merged commit 4230758 into main Aug 21, 2024
30 checks passed

oguzkaganozt deleted the refactor/pid_longitudinal_controller branch August 21, 2024 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(control/pid_longitudinal_controller): rework parameters #6707

refactor(control/pid_longitudinal_controller): rework parameters #6707

oguzkaganozt commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

stale bot commented Jun 4, 2024

vividf commented Aug 6, 2024

github-actions bot commented Aug 12, 2024 •

edited

Loading

oguzkaganozt commented Aug 12, 2024

oguzkaganozt commented Aug 15, 2024

takayuki5168 left a comment

codecov bot commented Aug 21, 2024 •

edited

Loading

yuki-takagi-66 commented Aug 26, 2024

refactor(control/pid_longitudinal_controller): rework parameters #6707

refactor(control/pid_longitudinal_controller): rework parameters #6707

Conversation

oguzkaganozt commented Mar 28, 2024 • edited Loading

Description

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

github-actions bot commented Apr 3, 2024 • edited Loading

stale bot commented Jun 4, 2024

vividf commented Aug 6, 2024

github-actions bot commented Aug 12, 2024 • edited Loading

oguzkaganozt commented Aug 12, 2024

oguzkaganozt commented Aug 15, 2024

takayuki5168 left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 21, 2024 • edited Loading

Codecov Report

yuki-takagi-66 commented Aug 26, 2024

oguzkaganozt commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Aug 12, 2024 •

edited

Loading

codecov bot commented Aug 21, 2024 •

edited

Loading