Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): don't avoid merging/deviating vehicle whose overhang distance is larger than threshold #6808

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 15, 2024

Description

Related PR: autowarefoundation/autoware_launch#974
Related ticket: https://tier4.atlassian.net/browse/RT1-5553

Previous avoidance module creates avoidance path for merging/deviating vehicle. However, sometimes it caused unnatural behavior as follow. In this situation, perception module detected ghost deviationg vehicle and module tried to avoid it with huge leteral shift length. I think the ego should stop behind of the it even if it's not perception false positive because most of the rear of the vehicle is still in Ego's lane.

image

In this PR, I fixed logic to check overhang distance and ignore such a vehicle.

            "merging_vehicle": {
              "type": "object",
              "properties": {
                "th_overhang_distance": {
                  "type": "number",
                  "description": "Distance threshold between overhang point and ego lane's centerline. If the nearest overhang point of merging/deviating vehicle is less than this param, the module never avoid it. (Basically, the ego stops behind of it.)",
                  "default": 0.5
                }
              },
              "required": ["th_overhang_distance"],
              "additionalProperties": false
            }

image

Tests performed

Effects on system behavior

Improve avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 15, 2024
@satoshi-ota satoshi-ota changed the title Fix/avoidance merging vehicle fix(avoidance): don't avoid merging/deviating vehicle whose overhang distance is larger than threshold Apr 15, 2024
@satoshi-ota satoshi-ota force-pushed the fix/avoidance-merging-vehicle branch from 4e5a2b0 to 56440a5 Compare April 15, 2024 04:45
@satoshi-ota satoshi-ota force-pushed the fix/avoidance-merging-vehicle branch from 56440a5 to b69170a Compare April 25, 2024 01:38
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 29, 2024
@satoshi-ota satoshi-ota merged commit b630838 into autowarefoundation:main Apr 30, 2024
36 of 39 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-merging-vehicle branch April 30, 2024 03:03
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 2, 2024
…distance is larger than threshold (autowarefoundation#6808)

* fix(avoidance): add target filtering threshold for merging/deviating vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): apply logic only for non-parked vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): align logger namespace

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 2, 2024
…distance is larger than threshold (autowarefoundation#6808)

* fix(avoidance): add target filtering threshold for merging/deviating vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): apply logic only for non-parked vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): align logger namespace

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 10, 2024
…distance is larger than threshold (autowarefoundation#6808)

* fix(avoidance): add target filtering threshold for merging/deviating vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): apply logic only for non-parked vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): align logger namespace

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…distance is larger than threshold (autowarefoundation#6808)

* fix(avoidance): add target filtering threshold for merging/deviating vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): apply logic only for non-parked vehicle

Signed-off-by: satoshi-ota <[email protected]>

* fix(avoidance): align logger namespace

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants