Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mrm_emergency_stop_operator): improve readability and change to read topic by polling #7313

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Jun 6, 2024

Description

Based on the discussion, change emergency_handler and mrm_handler to read topic by polling instead of best_effort callback.
In addition, readability was improved by reducing variable reuse.

Tests performed

psim test were performed

Effects on system behavior

nothing

Interface changes

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Autumn60 Autumn60 marked this pull request as ready for review June 6, 2024 08:51
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 6, 2024
@tkimura4 tkimura4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 11, 2024
@Autumn60
Copy link
Contributor Author

@mkuri
@TomohitoAndo

Could you review this PR as a code owner?

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (3d849e9) to head (2d35d5b).
Report is 1168 commits behind head on main.

Files Patch % Lines
...stop_operator/mrm_emergency_stop_operator_core.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7313       +/-   ##
===========================================
+ Coverage   15.09%   28.63%   +13.53%     
===========================================
  Files        1967     1593      -374     
  Lines      135941   116056    -19885     
  Branches    42122    49470     +7348     
===========================================
+ Hits        20520    33227    +12707     
+ Misses      92700    73913    -18787     
+ Partials    22721     8916    -13805     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.70% <ø> (+13.60%) ⬆️ Carriedforward from e84352f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Autumn60 Autumn60 closed this Aug 20, 2024
@Autumn60 Autumn60 deleted the feat/mrm_emergency_stop_operator/sub_by_polling branch August 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants