refactor(autoware_behavior_velocity_speed_bump_module): prefix package and namespace with autoware #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
requested review from
mehmetdogru,
shmpwk,
tkimura4,
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
taikitanaka3,
takayuki5168 and
TomohitoAndo
as code owners
esteve
added
the
tag:run-build-and-test-differential
github-actions
bot
added
type:documentation
maxime-clem
approved these changes
Jun 12, 2024
esteve
force-pushed
the
prefix-behavior_velocity_speed_bump_module
branch
from
3153e1f
to
e0107d0
Compare
|
@esteve Doesn't the CODEOWNERS file need to be updated too? |
auto-merge was automatically disabled
June 18, 2024 10:25
Pull request was closed
esteve
force-pushed
the
prefix-behavior_velocity_speed_bump_module
branch
from
e0107d0
to
c9c58f8
Compare
github-actions
bot
added
the
type:ci
|
@danielsanchezaran I've updated the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7467 +/- ##
===========================================
- Coverage 14.84% 12.40% -2.44%
===========================================
Files 1999 438 -1561
Lines 139163 36354 -102809
Branches 43716 5541 -38175
===========================================
- Hits 20661 4511 -16150
+ Misses 95731 31377 -64354
+ Partials 22771 466 -22305
☔ View full report in Codecov by Sentry. |
esteve
force-pushed
the
prefix-behavior_velocity_speed_bump_module
branch
from
fd7f9fe
to
3cc5f40
Compare
4 tasks
|
@xmfcx @mitsudome-r @satoshi-ota @shmpwk could you have a look at this PR when you have a moment? Thanks. |
shmpwk
approved these changes
Jun 19, 2024
esteve
force-pushed
the
prefix-behavior_velocity_speed_bump_module
branch
2 times, most recently
from
eef1e42
to
7e66167
Compare
|
@danielsanchezaran if the changes look ok to you, could you approve this PR? Thank you in advance. |
danielsanchezaran
approved these changes
Jun 20, 2024
…e and namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
prefix-behavior_velocity_speed_bump_module
branch
from
87a8d49
to
bfa7b7f
Compare
|
@danielsanchezaran fixed, thanks. |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…e and namespace with autoware (autowarefoundation#7467) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…e and namespace with autoware (autowarefoundation#7467) Signed-off-by: Esteve Fernandez <[email protected]>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…e and namespace with autoware (autowarefoundation#7467) Signed-off-by: Esteve Fernandez <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…e and namespace with autoware (#7467) Signed-off-by: Esteve Fernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
autowarefoundation/autoware#4569
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.